Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CfgValSet and RxmRawx packets. #23

Merged
merged 17 commits into from
Sep 10, 2022
Merged

Conversation

reitermarkus
Copy link
Collaborator

  • Add CFG_VAL_SET command and some of the values that can be set using it.
  • Add RXM_RAWX packet.

@reitermarkus reitermarkus force-pushed the cfg-val-set branch 2 times, most recently from d520cbb to 1bb615f Compare June 8, 2022 08:07
@reitermarkus reitermarkus force-pushed the cfg-val-set branch 2 times, most recently from 5e7991c to 66e6bfd Compare June 9, 2022 06:28
@lkolbly
Copy link
Collaborator

lkolbly commented Jun 11, 2022

Hey! Sorry for the delay. This is a good PR, I just haven't had enough time to sit down and look through it. I'm not going to be able to look at it for the next couple weeks, so I appreciate your patience in the meantime. Don't worry, it is on my list. :-)

@reitermarkus
Copy link
Collaborator Author

@lkolbly, ping on this. Hopefully you have some time to review this now.

If not, maybe consider adding another maintainer since there are also a bunch of other open PRs?

#[ubx_packet_recv]
#[ubx(class = 0x0d, id = 0x01, fixed_payload_len = 16)]
struct TimTp {
/// Time pulse time of week according to time base
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run cargo fmt on this? (I suspect the indentation will change)

ublox_derive/src/output.rs Outdated Show resolved Hide resolved
@lkolbly
Copy link
Collaborator

lkolbly commented Aug 30, 2022

@lkolbly, ping on this. Hopefully you have some time to review this now.

If not, maybe consider adding another maintainer since there are also a bunch of other open PRs?

Hey! Sorry, yes. I am still alive. Obviously, a couple weeks turned into a couple months (as they always do...).

I left some comments. Let me know if you get time to look at them, if not it's perfectly fine I can merge this as-is and handle it on my end.

@reitermarkus
Copy link
Collaborator Author

@lkolbly, I flipped the if and added the assertion that the iterator is the last field.

@lkolbly lkolbly merged commit fc4d9b6 into ublox-rs:master Sep 10, 2022
@reitermarkus reitermarkus deleted the cfg-val-set branch September 16, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants